Open
Conversation
sabernhardt
suggested changes
Jun 19, 2023
sabernhardt
left a comment
sabernhardt
left a comment
There was a problem hiding this comment.
This PR removes items that need to remain: the ie.css file, the twentytwelve-ie handle, an html tag, and the credit for the HTML5 Shiv (which is still included in the package).
- Restore the html tag deleted by mistake - Restore the credits - Restore the deleted file
- Restore the html tag deleted by mistake - Restore the credits - Restore the deleted file
Author
|
Thanks for the feedback @sabernhardt ! Applied the notes and changes, can you take a look is there anything else? if not, I'll open a new PR for the other themes, following the ticket updates. Thanks in advance! |
sabernhardt
reviewed
Jun 26, 2023
sabernhardt
left a comment
sabernhardt
left a comment
There was a problem hiding this comment.
I like that you changed "Load" to "Register" in another PR, keeping a verb. Similarly, Twenty Twelve should have "Registers" for its IE stylesheet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing IE specific checks from Twenty Twelve default theme. Keeping the
js/html5.jsas per the note from this commentWorking with @Neychok on the ticket, so we can split the work on the default themes.
Trac ticket: 56699