Replace include_once with require_once in twenty twenty one theme#4302
Closed
akramulhasan wants to merge 1 commit intoWordPress:trunkfrom
Closed
Replace include_once with require_once in twenty twenty one theme#4302akramulhasan wants to merge 1 commit intoWordPress:trunkfrom
akramulhasan wants to merge 1 commit intoWordPress:trunkfrom
Conversation
To improve consistency and ensure better security and stability of the code, I propose replacing include_once with require_once in these two files.
Member
|
Thanks for the PR! Merged in r55633. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the WordPress PHP coding standards, it is recommended to use require[_once] instead of include[_once] for unconditional includes. However, in two files of the twenty twenty one theme, I have found include_once used unconditionally.
To improve consistency and ensure better security and stability of the code, I propose replacing include_once with require_once in these two files.
This change will ensure that if the file cannot be found, a Fatal Error will be thrown, preventing any potential security leaks or other issues that may arise due to the file not being loaded properly.
I have created a pull request for these changes, and I kindly request a review from the WordPress core team.
Trac ticket: https://core.trac.wordpress.org/ticket/57839
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.