Added test post navigation link attribute filters#3808
Closed
creative-andrew wants to merge 7 commits intoWordPress:trunkfrom
Closed
Added test post navigation link attribute filters#3808creative-andrew wants to merge 7 commits intoWordPress:trunkfrom
creative-andrew wants to merge 7 commits intoWordPress:trunkfrom
Conversation
tests/phpunit/tests/link/postNavigationLinkAttributeFilters.php
Outdated
Show resolved
Hide resolved
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @creative-andrew Left one more review to use function instead of the variable.
tests/phpunit/tests/link/postNavigationLinkAttributeFilters.php
Outdated
Show resolved
Hide resolved
tests/phpunit/tests/link/postNavigationLinkAttributeFilters.php
Outdated
Show resolved
Hide resolved
costdev
requested changes
Feb 14, 2023
Contributor
costdev
left a comment
costdev
left a comment
There was a problem hiding this comment.
Hi @creative-andrew 👋 I've left some thoughts to help prep this for commit consideration. Thanks! 🙂
tests/phpunit/tests/link/postNavigationLinkAttributeFilters.php
Outdated
Show resolved
Hide resolved
tests/phpunit/tests/link/postNavigationLinkAttributeFilters.php
Outdated
Show resolved
Hide resolved
tests/phpunit/tests/link/postNavigationLinkAttributeFilters.php
Outdated
Show resolved
Hide resolved
tests/phpunit/tests/link/postNavigationLinkAttributeFilters.php
Outdated
Show resolved
Hide resolved
tests/phpunit/tests/link/postNavigationLinkAttributeFilters.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Contributor
|
@costdev change proposals committed :) |
Contributor
|
Committed in https://core.trac.wordpress.org/changeset/55429 |
Contributor
|
Reopening |
creative-andrew
requested review from
costdev
and removed request for
mukeshpanchal27
costdev
approved these changes
Feb 28, 2023
mukeshpanchal27
approved these changes
Mar 1, 2023
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @creative-andrew, The changes look good to me.
Member
|
Thanks for the PR! Merged in r55442 with a few minor edits:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/55751
This PR adds tests for
next_posts_link_attributes&previous_posts_link_attributesfilters and invalidates the patch #2725 submitted in the above-mentioned ticket as the current functionality is correct.