Enable multiple mime support with edit & restore flow #3030
Conversation
Co-authored-by: Joe Grainger <904708+jjgrainger@users.noreply.github.com>
Co-authored-by: Joe Grainger <904708+jjgrainger@users.noreply.github.com>
Co-authored-by: Joe Grainger <904708+jjgrainger@users.noreply.github.com>
…age_is_edited added
…tests. This aims to make the tests more specific. Setting the author appears to be redundant, as the as the authorship is out of scope for these particular tests. Follow-up to [66/tests], [84/tests], [167/tests], [296/tests], [412/tests], [496/tests], [1026/tests], [1323/tests], [25554], [33041], [34762], [35183]. See #55652. git-svn-id: https://develop.svn.wordpress.org/trunk@53787 602fd350-edb4-49c9-b593-d223f7449a82
|
Hi @mehulkaklotar! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Co-authored-by: Adam Silverstein <adamsilverstein@earthboundhosting.com>
|
@adamsilverstein I did some additional testing on latest changes. Thumbnails are now correct size. Tested "All sizes except thumbnail" as well which works correctly. |
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
@mehulkaklotar Left some more feedback.
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Left one feedback for the unit test.
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Left feedback for the unit test.
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
The code looks good now. Left some final review.
|
Thank you for the update. @mehulkaklotar The most recent commit, c1754ca, generates a bug for the thumbnail edit flow. It creates Is there any specific use case for these changes? |
|
@mukeshpanchal27 I have pushed changes to fix the issue you have mentioned. Please have a look. |
|
@mehulkaklotar looks like some tests are still failing here, can you take a look? |
|
@adamsilverstein It was an environment error when running checks. Fixed now! |
|
@mehulkaklotar - Since we reverted multi-mime support this is not currently needed, though it will come in handy if we reintroduce the feature so thanks for your work here! Closing for now. |
4 participants
This PR adds support for multiple mime types for image edit and restore. When image is deleted, it deletes all related files for that image, when it was edited or restored.
Trac ticket: https://core.trac.wordpress.org/ticket/55443
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.