Salting functions: translate the phrase put your unique phrase here.#2793
Closed
whaze wants to merge 4 commits intoWordPress:trunkfrom
Closed
Salting functions: translate the phrase put your unique phrase here.#2793whaze wants to merge 4 commits intoWordPress:trunkfrom
put your unique phrase here.#2793whaze wants to merge 4 commits intoWordPress:trunkfrom
Conversation
thx Peter Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
Contributor
|
Something that was mentioned in the original ticket is that there placeholder phrase appears elsewhere in WordPress and wordpress-develop/src/wp-includes/class-wp-recovery-mode-cookie-service.php Lines 200 to 234 in 5ebe289 @whaze are you able to look at accounting for those values too? I didn't realise until it was pointed out by another contributor on the ticket. |
Contributor
|
Closing in favor of #3289 which addresses @peterwilsoncc 's comments :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/55937
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.