#55674: Improve performance Search REST API#2744
Closed
manuelRod wants to merge 15 commits intoWordPress:trunkfrom
Closed
#55674: Improve performance Search REST API#2744manuelRod wants to merge 15 commits intoWordPress:trunkfrom
manuelRod wants to merge 15 commits intoWordPress:trunkfrom
Conversation
src/wp-includes/rest-api/search/class-wp-rest-post-search-handler.php
Outdated
Show resolved
Hide resolved
src/wp-includes/rest-api/search/class-wp-rest-post-search-handler.php
Outdated
Show resolved
Hide resolved
|
Why was limiting the fields to ids avoided to fetch the whole post data and then pluck the ids? |
Contributor
Doing a query for the entire post object will warm the object cache for the You raise a good point though, it's probably worth adding a comment explaining this in the code so a future developer doesn't change the query and cause extra database queries. |
peterwilsoncc
approved these changes
Jun 9, 2022
Contributor
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
Looks good to me, thank you!
src/wp-includes/rest-api/search/class-wp-rest-post-search-handler.php
Outdated
Show resolved
Hide resolved
Member
|
Committed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: #55674
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.