55078 Remove Hardcoded edit-tags from ajax js#2408
Closed
johnregan3 wants to merge 21 commits intoWordPress:trunkfrom
Closed
55078 Remove Hardcoded edit-tags from ajax js#2408johnregan3 wants to merge 21 commits intoWordPress:trunkfrom
johnregan3 wants to merge 21 commits intoWordPress:trunkfrom
Conversation
…oded-edit-tags-from-ajax
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes hardcoded check for
edit-tags-phpbody class from ajax-response.js. Instead allows for a "notice" value in the "supplemental" array.Renamed the JS var
successmsgtonoticemsgto clarify its purpose as admin notice text.Note in
ajax-actions.phparound ln 1118,$messageis used twice. When thedatavalue is removed from the array, tests fail intests/phpunit/tests/ajax/AddTag.php. TBH, I can't track down exactly why.Trac ticket: https://core.trac.wordpress.org/ticket/55078
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.