Skip to content

Fixed 20px to 2px#2309

Closed
Neychok wants to merge 16 commits intoWordPress:trunkfrom
Neychok:ticket/45925
Closed

Fixed 20px to 2px#2309
Neychok wants to merge 16 commits intoWordPress:trunkfrom
Neychok:ticket/45925

Conversation

@Neychok
Copy link
Copy Markdown

@Neychok Neychok commented Feb 11, 2022

The original diff submitted by @danfarrow did not work for me, so I recreated the diff while fixing the 20px in style-rtl.

Trac ticket: https://core.trac.wordpress.org/ticket/45925

Copy link
Copy Markdown
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Neychok! I added a small feedback :)

@Neychok Neychok requested a review from audrasjb February 13, 2022 22:37
outline-style: dotted;
text-decoration: underline;
text-decoration-skip-ink: auto;
text-decoration-thickness: 2px;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting change: removing the space before the tab on the text-decoration-thickness line

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it 👋

audrasjb
audrasjb previously approved these changes Jul 27, 2022
@audrasjb audrasjb dismissed their stale review September 14, 2022 22:46

Small changes

@audrasjb
Copy link
Copy Markdown
Contributor

Committed in https://core.trac.wordpress.org/changeset/54171

@audrasjb audrasjb closed this Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants