Remove experimental-link-color dependancy in global styles#2236
Closed
tommusrhodus wants to merge 1 commit intoWordPress:trunkfrom
Closed
Remove experimental-link-color dependancy in global styles#2236tommusrhodus wants to merge 1 commit intoWordPress:trunkfrom
tommusrhodus wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Removes experimental-link-color dependancy in global styles for themes to be able to update --wp--preset variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 5.9 it appears that fonts and colours defined in
theme.jsonwill correctly override the default values of--wp--preset--variables, however those defined viaadd_theme_supportare not, and so the default values are still being used.This is being triggered by whether or not a theme calls
add_theme_support( 'experimental-link-color' )A simple way to test what's going on here:
largeand set the background color toblackfunctions.phpand editline 170to change the large font size, and then editline 203to change the black color and save.Result: Paragraph text correctly reflects changes made to font size and color.
functions.phpand deleteline 333: add_theme_support( 'experimental-link-color' );Result: Font size and color fallback to WP default values.
Expected behaviour: Font sizes and colors set via
add_theme_supportshould continue to work as pre 5.9 without the need to addadd_theme_support( 'experimental-link-color' );ortheme.jsonThis PR removes
experimental-link-colordependancy inwp-includes/global-styles-and-settings.phpfor themes to be able to update--wp--presetvariables without the need to setuptheme.jsonor add theme support for an experimental feature.Trac ticket: https://core.trac.wordpress.org/ticket/54954