Skip to content

Administration: Remove bold from success notices - #15773

Open
mayankmajeji wants to merge 1 commit into
WordPress:trunkfrom
mayankmajeji:fix/37280-remove-bold-from-notices
Open

Administration: Remove bold from success notices#15773
mayankmajeji wants to merge 1 commit into
WordPress:trunkfrom
mayankmajeji:fix/37280-remove-bold-from-notices

Conversation

@mayankmajeji

@mayankmajeji mayankmajeji commented Nov 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Removes the <strong> wrapper from admin notices where the whole message is bold, so they match notices like "Plugin activated." that are already plain text.

This refreshes the earlier patches on the ticket (props Presskopp and jpolakovic on Trac) against current trunk. Since those patches, most of these notices moved to wp_admin_notice(), so none of the old patches apply.

Changes:

  • settings_errors() no longer wraps every message in <strong>. This is the "Settings saved." notice on every Settings screen.
  • "Profile updated." and "User updated." in user-edit.php
  • The term update notice in edit-tag-form.php (for example "Category updated.")
  • "Administration email updated." in options-general.php
  • "Settings saved." and "Network admin email updated." in network/settings.php
  • "Settings saved." in my-sites.php
  • The menu name in "%s has been updated." in wp_nav_menu_update_menu_items()

Bold labels that introduce a message ("Error:", "Warning:", "Caution:", "For more information:") are left as they are.

Trac ticket: https://core.trac.wordpress.org/ticket/37280

Testing

Tested on WordPress 7.2-beta4-65325 (nightly), PHP 8.2.27, nginx 1.26.1, MySQL 8.0.35, Chrome on macOS. For each notice, I checked the notice markup and its computed font-weight before and after the patch:

Notice Before After
Settings saved. (Settings > Reading) <strong>, 600 plain, 400
Administration email updated. <strong>, 600 plain, 400
Profile updated. <strong>, 600 plain, 400
Category updated. <strong>, 600 plain, 400
Test Menu has been updated. (Twenty Twenty-One) menu name <strong>, 600 plain, 400

Not tested by hand: "User updated." (same pattern as "Profile updated." in the same file) and the three multisite notices.

Screenshots are attached to the Trac ticket.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Searching trunk for bolded notices, drafting the change, and running the before/after checks on my local install. I reviewed every line of the diff and the test results, and edited this description.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@mayankmajeji
Administration: Remove bold from success notices.
a388131 
Removes the `<strong>` wrapper from admin notices where the whole message
is bold, so they match notices such as "Plugin activated." that are
already plain text. This includes the wrapper in `settings_errors()`,
which made every "Settings saved." notice bold.

Bold labels that introduce a message, such as "Error:" or "Warning:",
are unchanged.

See #37280.
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mayankmajeji.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@joedolson
joedolson self-requested a review November 7, 2026 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joedolson joedolson Awaiting requested review from joedolson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mayankmajeji