Repository navigation
Conversation
WP::handle_404() never sent a 404 for a feed, so feeds for tags, categories, authors and posts that don't exist returned an empty feed with a 200 status. Search engines keep requesting those URLs. Feeds now 404 when the queried tag, category, term, post type, author or post doesn't exist. Empty feeds for existing objects, and home, search, date and comment feeds, still return a 200, as before.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
WP::handle_404()listsis_feed()among the queries that never get a 404. So/tag/no-such-tag/returns 404, but/tag/no-such-tag/feed/returns 200 with an empty feed. Search engines keep requesting those URLs.This patch keeps that exemption only for feeds that aren't about a specific object. Tag, category, term, post type, author and singular feeds now return 404 when the object doesn't exist. Feeds for objects that do exist are already exempted by the existing
get_queried_object()and author checks, so empty archives keep their 200 (the behaviour from #18505).WP_Query::set_404()keepsis_feed, so the response is still a feed, now sent with a 404 status.Trac ticket: https://core.trac.wordpress.org/ticket/56883
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Reproducing the issue, drafting the patch and tests, and writing this description. I reviewed, tested and edited the final implementation and tests.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.