Repository navigation
Conversation
Sites that never changed their language have no `WPLANG` row, so `get_locale()` ran an options query on every request without a persistent object cache. `populate_options()` now adds an autoloaded empty `WPLANG` on single sites. This covers new installs and, through `upgrade_all()`, existing sites on the next database upgrade. A `WPLANG` constant set to a locale keeps taking precedence. When a single site is converted to a network, an empty `WPLANG` is removed from the main site so that it keeps falling back to the network language.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Sites that never changed their language have no
WPLANGrow, soget_option( 'WPLANG' )inget_locale()missesalloptionsand queries the database on every request without a persistent object cache.This refreshes #476 against current trunk:
populate_options()adds an autoloaded emptyWPLANGon single sites. Becauseupgrade_all()callspopulate_options(), existing sites get it on the next database upgrade. The$wp_db_versionbump is left for commit.WPLANGconstant set to a locale is respected (no row is added), since the option would otherwise override it.populate_network()removes an emptyWPLANGfrom the main site when converting a single site to a network. Without this, the main site ignored the network language.Trac ticket: https://core.trac.wordpress.org/ticket/50980
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Reproducing the issue, investigating the previous PR's test failure, and drafting the code and tests. I directed the approach and reviewed the final changes.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.