Repository navigation
Bundled Themes: Sync Ipsum with its GitHub repository - #15113
MaggieCabrera wants to merge 13 commits into
Conversation
The table header cells used `text-align: left`, so in right-to-left languages the labels sat on the left while their columns sat on the right. `start` follows the reading direction, so nothing changes in left-to-right languages. Synced from WordPress/ipsum#158. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ton inside. When the button sits inside the field, core removes the input outline without adding one to the wrapper, so keyboard users saw no focus indicator. The wrapper now shows the native focus ring while the input has focus. Synced from WordPress/ipsum#141. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Screen readers no longer read out decorative characters such as the `·` and `›` separators in post meta, the `›` in Read more, the `↑` in Back to top, and the quote marks on quotes and pullquotes. They still show on screen, but are now hidden from assistive technology. Synced from WordPress/ipsum#142. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… and adding screen reader text to the comments call to action. Post dates no longer link to the post, since the title and featured image already do, so lists of posts no longer have duplicate links with the same name. The "Join the conversation" and "Be the first to comment" links now include the post title as screen reader text, so each one has a unique name. Synced from WordPress/ipsum#93. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On single posts of a post type that does not support authors, the Author Name block renders nothing, which left an orphan "Written by" byline and avatar. The author card is now hidden in that case, and stays unchanged for posts and post types that support authors. Synced from WordPress/ipsum#167. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the wide footer. Hidden patterns now have capitalized, human-readable titles instead of raw slugs, and the Wide Footer pattern has a description in the inserter. Synced from WordPress/ipsum#77. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
| <div class="wp-block-group"><!-- wp:post-excerpt {"showMoreOnNewLine":false} /--> | ||
|
|
||
| <!-- wp:read-more {"content":"<?php esc_attr_e( 'Read more ›', 'ipsum' ); ?>"} /--></div> | ||
| <!-- wp:read-more {"content":"<?php esc_attr_e( 'Read more', 'ipsum' ); ?>\u003cspan aria-hidden=\u0022true\u0022\u003e <?php esc_attr_e( '›', 'ipsum' ); ?>\u003c/span\u003e"} /--></div> |
There was a problem hiding this comment.
Aside: This is a great example where a block attributes JSON encoding helper as proposed in WordPress/ipsum#172 would be very useful! It would avoid the need to hard-code unicode escapes for HTML markup embedded inside of JSON embedded inside of an HTML comment.
There was a problem hiding this comment.
if every default theme is going to need one, then I think we should find a core solution that solves it for them all. I'd be happy to review that
The links in the Categories block were too close together for the WCAG 2.2 minimum target size, so a touch could hit the wrong category. There is now a small space between the items, which applies to the sidebar and to any Categories block a site adds. Synced from WordPress/ipsum#176. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… slugs. The palette now uses the Twenty Twenty-Five color slugs, so patterns written for the default themes pick up Ipsum's colors. Each color is also named by its role, so the Site Editor shows names like Base, Contrast and Accent instead of numbered colors. Nothing looks different. Synced from WordPress/ipsum#179. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
I am sorry I was on holiday on Monday, but I have kept this PR to cover the sync of the work in Ipsum's repo back to core, so it would be nice if we can have it merged before the beta this week. Thank you! |
Ipsum registers a read-only `ipsum/get-design-guide` ability with the Abilities API. It returns the theme's colors and what each one is for, its fonts, sizes and spacing, its style variations, and its patterns and templates, so agents building pages can follow the design without seeing the theme's files. Synced from WordPress/ipsum#182. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
In dark color variations, the header submenus showed core's white background and black text, and core's border disappeared. The header navigation now gives submenus the palette's Base and Contrast colors and a Border-colored border in every variation. Synced from WordPress/ipsum#189. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The last header menu item's submenus ran past the right edge of the window. Core only flips submenus when the Navigation block is justified right, so the header navigation is now justified right. It already sat at the end of the row, so its items don't move. Synced from WordPress/ipsum#188. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sed. Post lists no longer show "Be the first to comment" or orphan separators when comments are closed, and single posts no longer show two separators with an empty gap between them. On single posts, the separators are now top borders on the Comments and Keep Reading blocks, so a line goes away with its block. Synced from WordPress/ipsum#184. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…and Search Bar. The sticky header's stacking context kept the open overlay below the admin bar, which covered its close button on small screens, and level with the pinned Search Bar, which was painted on top of it. The sticky header now rises above both only while the overlay is open. Synced from WordPress/ipsum#135. See #66352. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
| ), | ||
| 'output_schema' => $output_schema, | ||
| 'execute_callback' => 'ipsum_get_design_guide', | ||
| 'required_capabilities' => array( 'edit_theme_options' ), |
There was a problem hiding this comment.
https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-content/themes/ipsum/readme.txt
Requires at least: 7.2
This should be fine if not planned to be allowed with older WP versions.
Mamaduka
left a comment
There was a problem hiding this comment.
Approving and committing based on discussion in the release leads Slack channel (requires logic).
Follow-up work:
- Fix PHPStan level 10 errors - WordPress/ipsum#171.
- Polish theme Abilities; this also includes fixing PHPStan errors for the new file.
Brings over the changes merged in Ipsum's GitHub repository: - Add a design guide ability, so AI agents can read the theme's palette, typography, spacing, style variations, patterns and templates through the Abilities API. - Name the palette colors by role and use the Twenty Twenty-Five slugs. - Color the header submenus with the palette, and open them leftwards so they stay on screen. - Hide the comments call to action and its separators when comments are closed. - Keep the Header Sticky navigation overlay above the admin bar and Search Bar. - Hide the author card for post types without author support. - Restore a visible focus state to the Search block with the button inside. - Hide decorative characters from screen readers. - Fix ambiguous link texts by removing redundant post date links and adding screen reader text to the comments call to action. - Space the sidebar category links to meet the 24px target size. - Align table header labels with their columns in RTL. - Standardize titles in hidden patterns and add a description to the wide footer pattern. Developed in #15113. Follow-up to [64677]. Props onemaggie, sakshamsharma5, noruzzaman, khushalsains, matthewneilcowan, rahultank, juanfra, mikachan, ravipatel, iamarinoh, poena, peterwilsoncc, nilambar, prasadkarmalkar, karunyachavan84, nendeb55, westonruter, gziolo. See #66352. git-svn-id: https://develop.svn.wordpress.org/trunk@65224 602fd350-edb4-49c9-b593-d223f7449a82
|
Commited in 7a60249. |
Brings over the changes merged in Ipsum's GitHub repository: - Add a design guide ability, so AI agents can read the theme's palette, typography, spacing, style variations, patterns and templates through the Abilities API. - Name the palette colors by role and use the Twenty Twenty-Five slugs. - Color the header submenus with the palette, and open them leftwards so they stay on screen. - Hide the comments call to action and its separators when comments are closed. - Keep the Header Sticky navigation overlay above the admin bar and Search Bar. - Hide the author card for post types without author support. - Restore a visible focus state to the Search block with the button inside. - Hide decorative characters from screen readers. - Fix ambiguous link texts by removing redundant post date links and adding screen reader text to the comments call to action. - Space the sidebar category links to meet the 24px target size. - Align table header labels with their columns in RTL. - Standardize titles in hidden patterns and add a description to the wide footer pattern. Developed in WordPress/wordpress-develop#15113. Follow-up to [64677]. Props onemaggie, sakshamsharma5, noruzzaman, khushalsains, matthewneilcowan, rahultank, juanfra, mikachan, ravipatel, iamarinoh, poena, peterwilsoncc, nilambar, prasadkarmalkar, karunyachavan84, nendeb55, westonruter, gziolo. See #66352. Built from https://develop.svn.wordpress.org/trunk@65224 git-svn-id: http://core.svn.wordpress.org/trunk@64373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
WIP: This collects the Ipsum PRs merged this week. It'll be committed on Monday, November 2, not before, so it includes all of them.
Keeps Ipsum in core in sync with https://github.com/WordPress/ipsum. Each commit brings over one merged Ipsum PR and links it, so they can be committed together or one at a time.
Only theme files come over. Repository tooling and development docs stay on GitHub, like in the import.
Ipsum PRs included so far:
Trac ticket: https://core.trac.wordpress.org/ticket/66352
Testing Instructions
src/wp-content/themes/ipsummatches the theme files on Ipsum'strunk.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Watching the Ipsum repository for merges and bringing each one over as a commit. Every change was reviewed in its Ipsum PR.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code