Skip to content

HTTP API: Throw the global UnexpectedValueException in WpOrg\Requests\Iri::__wakeup() - #14842

Open
mpeshev wants to merge 1 commit into
WordPress:trunkfrom
mpeshev:60077-iri-wakeup-exception
Open

HTTP API: Throw the global UnexpectedValueException in WpOrg\Requests\Iri::__wakeup()#14842
mpeshev wants to merge 1 commit into
WordPress:trunkfrom
mpeshev:60077-iri-wakeup-exception

Conversation

@mpeshev

@mpeshev mpeshev commented Oct 25, 2026

Copy link
Copy Markdown

WpOrg\Requests\Iri::__wakeup() is declared in namespace WpOrg\Requests and throws new UnexpectedValueException() without a leading backslash. PHP then looks for WpOrg\Requests\UnexpectedValueException and throws an Error ("Class not found") instead, which a catch ( Exception $e ) around unserialize() does not catch.

The __wakeup() methods were added to the bundled Requests classes in [56835] and are not part of the upstream library (checked v2.0.17 and develop), so the fix belongs in core. Iri is the only one affected: Hooks and Session already throw \LogicException.

Trac ticket: https://core.trac.wordpress.org/ticket/60077

Testing

  • vendor/bin/phpunit --filter Tests_HTTP_RequestsIri fails without the patch with Class "WpOrg\Requests\UnexpectedValueException" not found and passes with it.
  • vendor/bin/phpunit --group http --exclude-group external-http passes.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: confirming the bug in trunk, drafting the fix and test, and running them. I reviewed every line.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

🤖 Generated with Claude Code

@mpeshev @claude
HTTP API: Throw the global UnexpectedValueException in `WpOrg\Reque…
d3b3525 
…sts\Iri::__wakeup()`.

The unserialize guard that core adds to the Requests IRI class throws `UnexpectedValueException` inside the `WpOrg\Requests` namespace without a leading backslash. PHP then looks for `WpOrg\Requests\UnexpectedValueException` and fails with a "Class not found" `Error`, which code that catches `Exception` around `unserialize()` cannot catch.

The guard was added in [56835] and is not part of the upstream library, so the fix belongs in core.

See #60077.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 25, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props nofearinc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

github-actions Bot commented Oct 25, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mpeshev