Repository navigation
Conversation
…al object comparisons In `tests/phpunit/tests/post/wpCountPosts.php` and `tests/phpunit/tests/post/wpCountAttachments.php`, several `assertEquals()` calls compare `stdClass` objects or arrays containing objects by value. These cannot be replaced with `assertSame()` because strict instance identity checks would fail for freshly-constructed or independently-retrieved objects. Add `// Keep assertEquals() because ...` annotations to document that each call was reviewed and intentionally kept as-is per the PHPUnit test cleanup effort for PHP 7.2 compatibility. Fixes #64895
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Author
|
Closing in favor of #14709 which covers the same files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/64895
Summary
In
tests/phpunit/tests/post/wpCountPosts.phpandtests/phpunit/tests/post/wpCountAttachments.php, severalassertEquals()calls comparestdClassobjects or arrays containing objects by value.These cannot be replaced with
assertSame()because strict instance identity checks would fail for freshly-constructed or independently-retrieved objects. For example:assertEquals( new stdClass(), wp_count_posts( 'not_a_post_type' ) )— two separate instances, same shapeassertEquals( (object) array( 'publish' => 5 ), $stored_counts )— object value comparisonassertEquals( array( $expected_counts, 'page', 'readable' ), $args[0] )— array containing a stdClassThis PR adds
// Keep assertEquals() because ...annotations to document that each call was reviewed and intentionally kept as-is, consistent with the approach used elsewhere in the test suite (e.g.tests/phpunit/tests/cron.php,tests/phpunit/tests/term/wpInsertTerm.php).Changes
tests/phpunit/tests/post/wpCountPosts.php: 3 annotations addedtests/phpunit/tests/post/wpCountAttachments.php: 2 annotations addedThis Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.