Repository navigation
Conversation
Previously, the classic editor's Publish meta box only rendered options for the built-in post statuses. When editing a post with a registered custom status, the Status label was empty and the status dropdown had no matching option, so the browser submitted the first option instead and saving the post silently changed its status to `pending`. The current post's custom status is now always included in the dropdown, its label is displayed, and the save button reads "Save as [status]". The new `post_submitbox_custom_statuses` filter allows additional custom statuses to be offered. Toggling visibility to Private and back to Public now restores the previously selected status. Developed in WordPress#12836. See WordPress#12706.
The value returned by the `post_submitbox_custom_statuses` filter is cast to an array, so a callback returning a string or `null` no longer causes a fatal error, and duplicate statuses are only rendered once. The per-option save text uses its own variable instead of overwriting the save button's label, and the filter's `@since` tag is corrected to 7.2.0. The tests are updated with typed methods, clearer fixture names, and coverage for non-array filter values and duplicate statuses. See WordPress#12706.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/12706
The classic editor's Publish meta box only renders options for the built-in post statuses. When editing a post that has a registered custom status (for example
in-review), the "Status:" label is empty and the status dropdown has no matching option. The browser then submits the first option, so clicking "Save Draft" silently changes the post's status topending:This PR takes the small scope discussed in comment:178 and comment:179: let registered custom statuses appear in the Publish meta box, without changing workflows, capabilities, or other screens.
Changes
post_submitbox_custom_statusesfilter to offer additional custom statuses in the dropdown. It receives the post, so statuses can be offered per post type. Custom statuses are opt-in, so existing sites do not suddenly see every registered status in the dropdown (see comment:135).Notes
publicorprivateare not treated as published by the meta box, since core still assumespublish(see comment:181). Feedback welcome on whether those should be excluded from the dropdown.register_post_status()argument such asshow_in_admin_status_dropdown, as proposed in comment:135. Happy to switch if that is preferred.Testing
New PHPUnit tests in
tests/phpunit/tests/admin/metaBoxes.phpand a QUnit test intests/qunit/wp-admin/js/post.js:Manual testing:
register_post_status( 'in-review', array( 'label' => 'In Review', 'protected' => true ) );in-review(e.g.wp post update <ID> --post_status=in-review).in-reviewstatus (on trunk it becomespending).add_filter( 'post_submitbox_custom_statuses', fn() => array( 'in-review' ) );and confirm it appears in the status dropdown of a draft.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.