Repository navigation
Build/Test Tools: Update PHPStan to 2.3.2 - #14830
Draft
westonruter wants to merge 1 commit into
Draft
westonruter wants to merge 1 commit into
westonruter wants to merge 1 commit into
Conversation
PHPStan 2.3.2 no longer reports `$authors_dropdown` as possibly undefined in `WP_Posts_List_Table::inline_edit()`, where it is echoed under the same `post_type_supports()` condition that defines it. Its entry is removed from the `variable.undefined` baseline, as regenerated by `composer phpstan:baselines`. The other baselines are unchanged, and the `phpstan/phpstan-phpunit` extension is already at its latest version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates PHPStan from 2.3.1 to 2.3.2. The
phpstan/phpstan-phpunitextension is already at its latest version (2.1.1).Baselines are regenerated with
composer phpstan:baselines. Onevariable.undefinedentry no longer matches:$authors_dropdowninWP_Posts_List_Table::inline_edit(), which is echoed under the samepost_type_supports()condition that defines it. Running 2.3.1 on that file still reports "Variable $authors_dropdown might not be defined", while 2.3.2 does not, so the change comes from the upgrade rather than from a stale baseline on trunk. The other baselines are unchanged, and a fullcomposer phpstan -- -c phpstan.neon.distreports no errors.Follow-up to r64334.
Trac ticket: https://core.trac.wordpress.org/ticket/65817
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Performing the upgrade, regenerating the baselines, verifying the dropped baseline entry against 2.3.1, and drafting this description.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code