Skip to content

Editor: Load classic theme styles from the block library build - #14826

Open
t-hamano wants to merge 2 commits into
WordPress:trunkfrom
t-hamano:66375-classic-theme-styles-from-gutenberg
Open

t-hamano wants to merge 2 commits into
WordPress:trunkfrom
t-hamano:66375-classic-theme-styles-from-gutenberg

Conversation

@t-hamano

Copy link
Copy Markdown
Contributor

Registers classic-theme-styles with wp-includes/css/dist/block-library/classic.css, which is synced from Gutenberg, instead of the hand-maintained wp-includes/css/classic-themes.css. The old file is removed, and the stylesheet now has RTL support.

Trac ticket: https://core.trac.wordpress.org/ticket/66375

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Implementation and PR description; reviewed by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

🤖 Generated with Claude Code

t-hamano and others added 2 commits October 24, 2026 20:32
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
*/
public function test_wp_maybe_inline_styles( ?string $additional_inline_style, ?int $styles_inline_size_limit ) {
$rel_path = 'css/classic-themes.css';
$rel_path = 'css/wp-block-template-skip-link.css';

@t-hamano t-hamano Oct 24, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classic-themes.css is removed in this PR, so these tests need another stylesheet. They only need a real CSS file and don't test the classic theme styles themselves.

wp-block-template-skip-link.css was chosen because it's committed to the repository and is small enough to stay within the default styles_inline_size_limit.

The other wp_maybe_inline_styles() tests below are updated the same way.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@t-hamano
t-hamano marked this pull request as ready for review October 24, 2026 11:38
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant