Repository navigation
Tests: Add unit test coverage for single_month_title(). - #14823
Open
rejaulalomkhan wants to merge 1 commit into
Open
rejaulalomkhan wants to merge 1 commit into
rejaulalomkhan wants to merge 1 commit into
Conversation
Covers titles built from the year and monthnum query variables and from m, their precedence, the prefix placement, the false result without a valid month, echo and return modes, and locale month names. See #65819.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for
single_month_title(), which had no test coverage.The tests cover:
yearandmonthnumquery variables and fromm(year-month and full date).year/monthnumoverm, and the fallback tomwhen onlymonthnumis set.falsewithout a valid month, in both modes, and month names from$wp_locale.This is a test-only change; no production code is modified.
Testing Instructions
npm run test:php -- --filter Tests_General_SingleMonthTitlenpm run test:php -- -c tests/phpunit/multisite.xml --filter Tests_General_SingleMonthTitlenpm run test:php -- --group generalTrac ticket: https://core.trac.wordpress.org/ticket/65819
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Drafting the tests and running the checks. I reviewed the changes, ran the tests locally, and take responsibility for them.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.