Repository navigation
Conversation
Add coverage for a single matching pattern, an integer property name, a pattern that matches only part of the name, a match on a later pattern, a pattern that contains the `#` delimiter, a multibyte property name that only matches with the Unicode modifier, and the cases that return null: no patternProperties keyword, an empty one, no matching pattern, and a `#` that has to match literally. See #65819.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests for
rest_find_matching_pattern_property_schema()intests/phpunit/tests/rest-api/restFindMatchingPatternPropertySchema.php. The function returns the schema of thepatternPropertiesentry that matches a property name. It is used by REST API validation, sanitization and filtering by context, and bywp_prepare_json_value_for_client(), to pick the schema for a property. It had no dedicated tests.Trac ticket: https://core.trac.wordpress.org/ticket/65819
What the tests cover
"123"reaches the function as the integer123.[0-9]matchesprop0.#, the regex delimiter, matchesa#band does not matchab.ématches^.$, which only works with the Unicode modifier.nullis returned when the schema has nopatternProperties, an empty one, or no pattern that matches.When more than one pattern matches a property, the function returns the first one. JSON Schema applies every matching pattern, so these tests do not cover overlapping patterns.
Test-only change.
Testing
All 10 test cases pass. Breaking the function or the pattern helper it uses in eight ways, such as checking only the first pattern, anchoring the pattern, dropping the Unicode modifier, or not escaping
#, makes 1 to 8 of them fail or error each time.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code and Codex
Used for: Choosing the function, writing the tests, checking them against the function's real output, and auditing the tests and this description. I reviewed the tests and the results, and I take responsibility for the contribution.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.