Repository navigation
Tests: Restore original theme after Customize Manager tests - #14818
Draft
shail-mehta wants to merge 1 commit into
Draft
shail-mehta wants to merge 1 commit into
shail-mehta wants to merge 1 commit into
Conversation
Save the active stylesheet before tests that switch themes and restore it after each test so theme state does not leak into later suites. Trac ticket: https://core.trac.wordpress.org/ticket/65893
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped cleanup fits the existing test lifecycle, with no blocking issues identified in static review.
No open issues 🎉
What changed in this PR
This PR improves Customize Manager test isolation by restoring the incoming theme after each test, preventing theme changes from affecting later tests in the same process.
Changes:
- Captures the original stylesheet during
set_up(). - Restores it during
tear_down()only when the stylesheet has changed.
| File | Description |
|---|---|
tests/phpunit/tests/customize/manager.php |
Saves and conditionally restores the active theme stylesheet. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: #65893
What
Restores the active theme stylesheet in
tear_down()withinTests_WP_Customize_Managerintests/phpunit/tests/customize/manager.php.Why
test_constructor_deferred_changeset_uuid()callsswitch_theme( 'twentyseventeen' )without restoring the incoming stylesheet, leaving later test suites in the same process on that theme.How
$this->original_stylesheet = get_stylesheet();duringset_up().switch_theme( $this->original_stylesheet );intear_down()when the stylesheet changed.Testing Instructions
npm run env:start && npm run env:install.npm run test:php -- --filter test_constructor_deferred_changeset_uuidnpm run test:php -- --test-suffix .php tests/phpunit/tests/customize --order-by=random --random-order-seed=1npm run test:php -- --test-suffix .php tests/phpunit/tests/customize --order-by=random --random-order-seed=2npm run test:php -- --test-suffix .php tests/phpunit/tests/customizeUse of AI Tools