Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the PHP test updates for WordPress/gutenberg#85396.
Core copies the action definitions from the Gutenberg build. That change supplies
Trashas the base label and adds a translated ellipsis when the action appears in a menu. This PR updates the registered-action assertion and both translation hooks in the default-text-domain test to expectTrash.Keep this PR as a draft until Core's Gutenberg pin includes WordPress/gutenberg#85396. The current pin still supplies
Trash…, so these test expectations require that sync.Testing Instructions
After syncing a Gutenberg build containing WordPress/gutenberg#85396, run:
The registered trash action should have the label
Trash, and its translation should use the default text domain.Local verification
PHP syntax and coding standards passed. Runtime PHPUnit verification is blocked locally because Docker has exhausted its network address pools.
Trac ticket: https://core.trac.wordpress.org/ticket/66343
Use of AI Tools
AI assistance: Yes. Codex ported the test expectations and drafted this description.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.