Repository navigation
Tests: Make data providers in file.php static - #14807
shail-mehta wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Both providers are independent of instance state, and the declaration changes preserve existing test behavior.
No open issues 🎉
What changed in this PR
This test-only PR makes two data providers static in Tests_File, aligning them with current PHPUnit expectations without changing production code.
Changes:
- Declares both filename data providers
public static. - Preserves existing datasets and test references.
| File | Description |
|---|---|
tests/phpunit/tests/file.php |
Makes both wp_tempnam() data providers static. |
Review effort: Balanced
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
What
Trac ticket: #65819
Makes the data providers in
tests/phpunit/tests/file.phpstatic.Why
PHPUnit data providers should be static so they do not depend on test instance state and remain compatible with current PHPUnit usage in Core.
How
data_wp_tempnam_filenames()topublic staticdata_wp_tempnam_should_limit_filename_length_to_252_characters()topublic staticTest-only; no production code changes.
Testing Instructions
npm run test:php -- --filter Tests_Filenpm run test:php -- --filter Tests_File -c tests/phpunit/multisite.xmlnpm run test:php -- --filter Tests_File --order-by=randomnpm run test:php -- --group fileUse of AI Tools