Repository navigation
Tests: Make data providers in locale.php static - #14806
Open
shail-mehta wants to merge 1 commit into
Open
shail-mehta wants to merge 1 commit into
shail-mehta wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Both providers are independent of instance state, and the declaration changes preserve their data and existing test references.
No open issues 🎉
What changed in this PR
Updates the locale tests’ data providers to be static, aligning them with current PHPUnit usage in WordPress Core.
Changes:
- Makes
data_property_initializes_to_array()anddata_get_word_count_type()public static methods. - Preserves provider data and test behavior; no production code changes.
| File | Description |
|---|---|
tests/phpunit/tests/locale.php |
Adds static to both data provider declarations. |
Review effort: Balanced
shail-mehta
marked this pull request as ready for review
October 25, 2026 03:38
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Trac ticket: #65819
Makes the data providers in
tests/phpunit/tests/locale.phpstatic.Why
PHPUnit data providers should be static so they do not depend on test instance state and remain compatible with current PHPUnit usage in Core.
How
data_property_initializes_to_array()topublic staticdata_get_word_count_type()topublic staticTest-only; no production code changes.
Testing Instructions
npm run test:php -- --filter Tests_Localenpm run test:php -- --filter Tests_Locale -c tests/phpunit/multisite.xmlnpm run test:php -- --filter Tests_Locale --order-by=randomnpm run test:php -- --group l10nUse of AI Tools