Repository navigation
KSES: Allow box-sizing in safecss_filter_attr() - #14708
Draft
draganescu wants to merge 1 commit into
Draft
draganescu wants to merge 1 commit into
draganescu wants to merge 1 commit into
Conversation
The layout block support gives a child with a fixed size in a flex layout `box-sizing: border-box`, but the style engine filters every declaration through `safecss_filter_attr()`, which dropped it. Synced from WordPress/gutenberg#85373. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 22, 2026
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
box-sizingto the CSS propertiessafecss_filter_attr()allows. Backport of Gutenberg #85373.The layout block support gives a block with a fixed width in a Row or Stack (
selfStretch: fixedwith aflexSize)flex-basisandbox-sizing: border-box, so its padding and borders stay inside the width set (wp_get_child_layout_style_rules()inblock-supports/layout.php). The style engine filters every declaration throughsafecss_filter_attr(), andbox-sizingisn't on its list, so the declaration is silently dropped and a padded fixed-width block ends up wider than the width set. Gutenberg's manual grid free placement (experimental) also relies on it.Adds a
box-sizing: border-boxcase toTests_Kses::data_safecss_filter_attr().Trac ticket:
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Writing the change, the test and this description, reviewed by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code