Repository navigation
Tests: Add unit test coverage for get_search_query() and the_search_query() - #14679
Open
rejaulalomkhan wants to merge 1 commit into
Open
rejaulalomkhan wants to merge 1 commit into
rejaulalomkhan wants to merge 1 commit into
Conversation
…h_query()`. Covers escaped and raw search queries, an empty search, the main query, the order of filtering and escaping in both functions, and the arguments and return values of the `get_search_query` and `the_search_query` filters. See #65819.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
huzaifaalmesbah
approved these changes
Oct 22, 2026
huzaifaalmesbah
left a comment
huzaifaalmesbah
left a comment
Member
There was a problem hiding this comment.
Thanks, @rejaulalomkhan! Nice coverage for get_search_query() and the_search_query(). LGTM.
AI Review: Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a test class for
get_search_query()andthe_search_query(), which had no direct tests.The tests cover:
get_search_query()escaping the query by default (Tom & "Jerry" <b>), returning it raw with$escaped = false, an empty string without a search, and reading the main query aftergo_to( '/?s=pizza+night' ).get_search_queryfilter receiving the raw query, with its result escaped afterwards.the_search_query()displaying the escaped query.the_search_queryfilter receiving the unescaped query (already passed throughget_search_query), with its result escaped once.Each behaviour was checked against a mutated source (escaping removed, filter skipped,
$escapeddefaulting tofalse, escaping removed from or doubled inthe_search_query(), its filter skipped); a test fails for every mutation.This is a test-only change; no production code is modified.
Testing Instructions
npm run test:php -- --filter Tests_General_GetSearchQuerynpm run test:php -- -c tests/phpunit/multisite.xml --filter Tests_General_GetSearchQuerynpm run test:php -- --group general --order-by=randomTrac ticket: https://core.trac.wordpress.org/ticket/65819
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Drafting the tests and running the checks. I reviewed the changes, ran the tests locally, and take responsibility for them.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.