Skip to content

Plugins: Update custom plugin group counts after deleting a plugin. #14675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huzaifaalmesbah wants to merge 6 commits into
base: trunk
Choose a base branch
from
+96 −0
Open

Plugins: Update custom plugin group counts after deleting a plugin. #14675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
46db25d
Plugins: Update custom plugin group counts after deleting a plugin.
huzaifaalmesbah Oct 22, 2026
6ba822d
Retrigger CI after the Build WordPress step timed out.
huzaifaalmesbah Oct 22, 2026
a79fca1
Plugins: Remove the separator left on the last plugin view after a vi…
huzaifaalmesbah Oct 22, 2026
84ed2e6
Plugins: Remove the trailing view separator the same way as `wp.updat…
huzaifaalmesbah Oct 22, 2026
23e9ea9
Plugins: Only look up custom plugin groups among the view items.
huzaifaalmesbah Oct 23, 2026
eff6b03
Plugins: Handle every remaining plugin group after a delete, not only…
huzaifaalmesbah Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/js/_enqueues/wp/updates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1447,6 +1447,24 @@
}
}

// Remove from the other groups, such as those added through the `plugins_list` filter.
_.each( _.keys( plugins ), function( group ) {
var $view;

if ( 'all' === group || ! _.isArray( plugins[ group ] ) || -1 === _.indexOf( plugins[ group ], response.plugin ) ) {
return;
}

plugins[ group ] = _.without( plugins[ group ], response.plugin );
$view = $views.children( 'li.' + $.escapeSelector( group ) );

if ( plugins[ group ].length ) {
$view.find( '.count' ).text( '(' + plugins[ group ].length + ')' );
} else {
$view.remove();
}
} );

plugins.all = _.without( plugins.all, response.plugin );

if ( plugins.all.length ) {
Expand All @@ -1460,6 +1478,9 @@
}
}

// Remove the trailing separator left on the last view when the view after it was removed.
$views.find( 'li:last' ).html( function() { return $( this ).children(); } );

if ( $itemsCount.length && $currentView.length ) {
remainingCount = plugins[ $currentView.parent( 'li' ).attr('class') ].length;
$itemsCount.text(
Expand Down
75 changes: 75 additions & 0 deletions tests/qunit/wp-admin/js/updates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,81 @@ jQuery( function( $ ) {
assert.equal( jQuery.ajax.getCall( 0 ).args[0].data.action, 'delete-plugin' );
assert.equal( jQuery.ajax.getCall( 0 ).args[0].data.slug, 'jetpack' );
} );
QUnit.test( 'Deleting a plugin should update the counts of custom plugin groups', function( assert ) {
var plugins = window._wpUpdatesSettings.plugins;

$( '#qunit-fixture' ).append(
'<script type="text/html" id="tmpl-item-deleted-row"><tr class="plugin-deleted-tr"><td colspan="{{ data.colspan }}"></td></tr></script>' +
'<ul class="subsubsub">' +
'<li class="all"><a href="#">All <span class="count">(3)</span></a> |</li>' +
Comment thread
huzaifaalmesbah marked this conversation as resolved.
'<li class="inactive"><a href="#">Inactive <span class="count">(2)</span></a> |</li>' +
'<li class="demo_group"><a href="#">Demo Group <span class="count">(2)</span></a> |</li>' +
'<li class="single_group"><a href="#">Single Group <span class="count">(1)</span></a></li>' +
'</ul>' +
'<form id="bulk-action-form"><table><tbody id="the-list">' +
'<tr data-plugin="custom-a/custom-a.php"><td></td></tr>' +
'</tbody></table></form>'
);

window._wpUpdatesSettings.plugins = {
all: [ 'custom-a/custom-a.php', 'custom-b/custom-b.php', 'other/other.php' ],
inactive: [ 'custom-a/custom-a.php', 'other/other.php' ],
demo_group: [ 'custom-a/custom-a.php', 'custom-b/custom-b.php' ],
single_group: [ 'custom-a/custom-a.php' ]
};

// Run the fade out callback right away.
sinon.stub( $.fn, 'fadeOut' ).callsFake( function( speed, callback ) {
return this.each( callback );
} );

wp.updates.deletePluginSuccess( { slug: 'custom-a', plugin: 'custom-a/custom-a.php', pluginName: 'Custom A' } );

$.fn.fadeOut.restore();

assert.equal( $( '.subsubsub .all .count' ).text(), '(2)', 'The All count should go down.' );
assert.equal( $( '.subsubsub .inactive .count' ).text(), '(1)', 'The Inactive count should go down only once.' );
assert.equal( $( '.subsubsub .demo_group .count' ).text(), '(1)', 'The custom group count should go down.' );
assert.strictEqual( $( '.subsubsub .single_group' ).length, 0, 'An empty custom group should be removed.' );
assert.strictEqual( $( '.subsubsub .all' ).text(), 'All (2) |', 'Separators between views should be kept.' );
assert.strictEqual( $( '.subsubsub .demo_group' ).text(), 'Demo Group (1)', 'The new last view should not end with a separator.' );
assert.deepEqual( window._wpUpdatesSettings.plugins.demo_group, [ 'custom-b/custom-b.php' ], 'The deleted plugin should be removed from the custom group.' );

window._wpUpdatesSettings.plugins = plugins;
} );
QUnit.test( 'Deleting a plugin should only remove the view of an emptied custom group', function( assert ) {
var plugins = window._wpUpdatesSettings.plugins;

$( '#qunit-fixture' ).append(
'<script type="text/html" id="tmpl-item-deleted-row"><tr class="plugin-deleted-tr"><td colspan="{{ data.colspan }}"></td></tr></script>' +
'<ul class="subsubsub">' +
'<li class="all"><a href="#">All <span class="count">(2)</span></a> |</li>' +
'<li class="count"><a href="#">Count <span class="count">(1)</span></a></li>' +
'</ul>' +
'<form id="bulk-action-form"><table><tbody id="the-list">' +
'<tr data-plugin="custom-a/custom-a.php"><td></td></tr>' +
'</tbody></table></form>'
);

// A group key that matches the class of the count elements.
window._wpUpdatesSettings.plugins = {
all: [ 'custom-a/custom-a.php', 'other/other.php' ],
count: [ 'custom-a/custom-a.php' ]
};

sinon.stub( $.fn, 'fadeOut' ).callsFake( function( speed, callback ) {
return this.each( callback );
} );

wp.updates.deletePluginSuccess( { slug: 'custom-a', plugin: 'custom-a/custom-a.php', pluginName: 'Custom A' } );

$.fn.fadeOut.restore();

assert.strictEqual( $( '.subsubsub > li.count' ).length, 0, 'The emptied group view should be removed.' );
assert.strictEqual( $( '.subsubsub .all' ).text(), 'All (1)', 'The All view should keep its count.' );

window._wpUpdatesSettings.plugins = plugins;
} );

// QUnit.test( 'A successful update changes the message?', function( assert ) {} );
// QUnit.test( 'A failed update changes the message?', function( assert ) {} );
Expand Down
Loading