Skip to content

Twenty Twenty-Five: Use generic no-results copy outside of search results - #14653

Open
irozum wants to merge 1 commit into
WordPress:trunkfrom
irozum:fix/63513-twentytwentyfive-no-results-copy
Open

Twenty Twenty-Five: Use generic no-results copy outside of search results#14653
irozum wants to merge 1 commit into
WordPress:trunkfrom
irozum:fix/63513-twentytwentyfive-no-results-copy

Conversation

@irozum

@irozum irozum commented Oct 21, 2026

Copy link
Copy Markdown

Description

On the Blog home template, Twenty Twenty-Five shows "Sorry, but nothing was found. Please try a search with different keywords." when the query has no posts. Asking for different keywords only makes sense on search results.

  • The shared template-query-loop pattern (used by index, home and archive) now says "No posts were found.", matching Twenty Twenty-Four, as suggested in the ticket.
  • A new hidden template-query-loop-search pattern keeps the original search wording, and search.html uses it.
  • The home-only patterns (template-home-news-blog, template-home-with-sidebar-news-blog, template-home-posts-grid-news-blog, page-portfolio-home) get the same generic copy.
  • The *-blog pattern variants shared between search and home are left unchanged and can be handled separately.

Trac ticket: https://core.trac.wordpress.org/ticket/63513

Testing

  • In the Site Editor, open the Blog home template and scroll to the footer: the empty-query text should read "No posts were found."
  • Visit a search with no matches (/?s=zzzzzz): the text should still ask for different keywords.
  • npm run test:php -- --filter Tests_Theme_TwentyTwentyFiveNoResultsCopy

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5.5
Used for: Implementation, tests, and PR description.

This Pull Request is for code review only. Please do not merge it on GitHub, as all commits must be made to SVN.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Oct 21, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props irozum.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Oct 21, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@irozum