Repository navigation
Conversation
`wp_unique_post_slug()` checked one numeric suffix per query, so a slug with N duplicates took N + 1 queries, and importing many posts with the same title grew quadratically. The suffix search now runs in a private helper, `_wp_unique_post_slug_add_suffix()`, which checks candidates in exact-match `post_name IN ( ... )` batches that double in size, starting at 1 and capped at 1,000. The result is unchanged: the lowest free suffix starting at 2, gaps are filled, and each candidate is truncated as before. When the database returns a name that matches a candidate only under the column's collation, free candidates are confirmed with the existing single-slug query.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
wp_unique_post_slug()checked one numeric suffix per query, so a slug with N duplicates took N + 1 queries, and importing many posts with the same title grew quadratically.The suffix search now runs in a private helper,
_wp_unique_post_slug_add_suffix(), which checks candidates in exact-matchpost_name IN ( ... )batches that double in size, starting at 1 and capped at 1,000. The result is unchanged: the lowest free suffix starting at 2, gaps are filled, and each candidate is truncated as before.Additionally, The PHPStan baseline count for
strlen()given an int inpost.phpdrops from 3 to 1, since the three suffix loops are now one helper.Trac ticket: https://core.trac.wordpress.org/ticket/39603
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 5.5
Used for: Initial research on finding element in unbounded range with gaps. Final implementation and tests were reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.