Repository navigation
Tests: Port the Gutenberg tests of the action links and the view config schema - #14518
Closed
jorgefilipecosta wants to merge 1 commit into
Closed
jorgefilipecosta wants to merge 1 commit into
jorgefilipecosta wants to merge 1 commit into
Conversation
…ig schema. Adds the Gutenberg cases Core lacks: the trash action link is absent in the view context and when the user cannot delete the post, the homepage and posts page action links of the pages in a collection are compacted as the editors read them, and the view config schema describes the table column styles. See #63670, #66327, #65981.
jorgefilipecosta
marked this pull request as ready for review
October 19, 2026 21:01
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
wporg-sync
pushed a commit
that referenced
this pull request
Oct 20, 2026
Adds the Gutenberg PHPUnit tests that have no Core counterpart yet, for code Core already has: - The `action-trash` link is absent in the `view` context and when the user cannot delete the post. - The `action-set-homepage` and `action-set-posts-page` links of pages in a collection are compacted as `wp:action-set-homepage` and `wp:action-set-posts-page`, the keys the core actions read. - The view config schema describes the table column styles. Developed in: #14518 Props jorgefilipecosta. See #63670, #66327, #65981. git-svn-id: https://develop.svn.wordpress.org/trunk@64596 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Oct 20, 2026
Adds the Gutenberg PHPUnit tests that have no Core counterpart yet, for code Core already has: - The `action-trash` link is absent in the `view` context and when the user cannot delete the post. - The `action-set-homepage` and `action-set-posts-page` links of pages in a collection are compacted as `wp:action-set-homepage` and `wp:action-set-posts-page`, the keys the core actions read. - The view config schema describes the table column styles. Developed in: WordPress/wordpress-develop#14518 Props jorgefilipecosta. See #63670, #66327, #65981. Built from https://develop.svn.wordpress.org/trunk@64596 git-svn-id: http://core.svn.wordpress.org/trunk@63746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the Gutenberg PHPUnit tests that have no Core counterpart yet, for code Core already has.
This PR adds:
test_trash_action_does_not_exist_in_view_contextandtest_trash_action_does_not_exist_when_user_cannot_deleteto the posts controller tests, from rest-trash-action-link-test.php.test_homepage_action_links_exist_for_pages_in_a_collectionto the pages controller tests, from rest-homepage-action-links-test.php (Actions API: Register the homepage and posts page actions using REST links gutenberg#84932). It checks the compactedwp:action-set-homepageandwp:action-set-posts-pagekeys that the core actions read.test_get_item_schema_describes_table_column_stylesto the view config controller tests, from class-gutenberg-rest-view-config-controller-7-2-test.php.It leaves out
test_get_items_wp_navigation_default_view, which needs thewp_navigationview config of #13296.Trac tickets: https://core.trac.wordpress.org/ticket/63670, https://core.trac.wordpress.org/ticket/66327, https://core.trac.wordpress.org/ticket/65981
Testing Instructions
Verify unit tests are passing:
Use of AI Tools
AI assistance: Yes
Used for: porting the tests from Gutenberg and drafting this description; reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.