Skip to content

REST API: Treat duplicate meta rows already holding the submitted value as unchanged - #14505

Open
irozum wants to merge 1 commit into
WordPress:trunkfrom
irozum:fix/55467-rest-meta-duplicate-rows-same-value
Open

REST API: Treat duplicate meta rows already holding the submitted value as unchanged#14505
irozum wants to merge 1 commit into
WordPress:trunkfrom
irozum:fix/55467-rest-meta-duplicate-rows-same-value

Conversation

@irozum

@irozum irozum commented Oct 19, 2026

Copy link
Copy Markdown

Updating a single registered meta key through the REST API returns a 500 rest_meta_database_error when the object has more than one row for that key and the submitted value equals the stored value. The existing "unchanged value" pre-check in WP_REST_Meta_Fields::update_meta_value() only runs when exactly one row exists, so with duplicate rows update_metadata() runs an UPDATE that affects 0 rows and returns false, which is reported as a database error.

Changes

  • Treat the value as unchanged when every stored row already matches the submitted value, via a new are_all_stored_values_same() helper.
  • Add a REST post meta test covering two identical rows; it returns 500 without the fix and 200 with it.

Trac ticket: https://core.trac.wordpress.org/ticket/55467

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5.5
Used for: Implementation, tests, and PR description.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Oct 19, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props irozum.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Oct 19, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@irozum