Administration: Create site icon sizes for exact-size images in General Settings. - #14280

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ravipatel, adamsilverstein.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Thanks for the PR @rvpatel - the code looks fine on the face of it, but I'm not sure this is the best approach. It creates an additional request and could require different capabilities than the current flow, possibly silently failing.

I chatted with Claude about this to come up with some alternate approaches. I chose a couple possibilities to consider:

1. Create the sizes when the site_icon option is saved

Essentially silently fix the issue silently by creating the missing sizes when the option gets saved.

// hook add_option_site_icon and update_option_site_icon. If the attachment has no site_icon-* sizes, create only the missing ones:
$wp_site_icon = new WP_Site_Icon();
$new_sizes    = $wp_site_icon->additional_sizes( wp_get_registered_image_subsizes() );
$metadata     = _wp_make_subsizes( $new_sizes, get_attached_file( $id ), wp_get_attachment_metadata( $id ), $id );

The advantage here is it ensures site icons always work, no matter where the icon comes from , including REST and WP-CLI. It feels a little kludgy to me though.

4. Match the Customizer: always show the cropper with a "Skip Cropping" button

This is what @jorbin and @joedolson asked for on https://core.trac.wordpress.org/ticket/64020. It makes the two screens behave the same.

"Skip Cropping" in the Customizer still sends the full image through crop-image, so it keeps the duplicate copy and the re-encoding.So its the current PR with an extra button. It would fix #64020 and #66309 together.

What do you think?