Repository navigation
Connectors: Prompt for filesystem credentials when installing connect… - #14268
devharshit wants to merge 1 commit into
Conversation
…or plugins. When the filesystem method requires credentials which have not been stored (for example, when `FS_METHOD` is `ftpext`), installing a connector plugin from Settings > Connectors fails, as the REST API plugins endpoint cannot accept filesystem credentials. This enqueues the `updates` script and prints the "Connection Information" modal on the Connectors screen, matching Plugins > Add Plugin. It also exposes a `filesystemCredentialsRequired` flag to the Connectors script module, so that the client can install via `wp.updates.installPlugin()` in exactly the cases where the REST API would fail. See #65223. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Thanks for the PR. However, let me close this in favor of #13953. |
…or plugins.
When the filesystem method requires credentials which have not been stored (for example, when
FS_METHODisftpext), installing a connector plugin from Settings > Connectors fails, as the REST API plugins endpoint cannot accept filesystem credentials.This enqueues the
updatesscript and prints the "Connection Information" modal on the Connectors screen, matching Plugins > Add Plugin. It also exposes afilesystemCredentialsRequiredflag to the Connectors script module, so that the client can install viawp.updates.installPlugin()in exactly the cases where the REST API would fail.See #65223.
Trac ticket:
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.