Skip to content

Administration: Move core admin notices after the main heading - #14252

Open
Adi-ty wants to merge 2 commits into
WordPress:trunkfrom
Adi-ty:fix/66302-admin-notices-after-h1
Open

Adi-ty wants to merge 2 commits into
WordPress:trunkfrom
Adi-ty:fix/66302-admin-notices-after-h1

Conversation

@Adi-ty

@Adi-ty Adi-ty commented Oct 13, 2026

Copy link
Copy Markdown

Four core notices on admin_notices / network_admin_notices use the inline class, so moveAdminNotices() from 64282 skips them and they render before the main H1, outside aside#wp-admin-notices.

This patch removes inline from:

  • update_nag() — update available notice
  • maintenance_nag() — failed update notice
  • site_admin_notice() — "Upgrade Network" notice
  • WP_Privacy_Policy_Content::notice() — privacy policy guide notice

It also adds #wp-admin-notices .update-nag { display: block; }, since .update-nag is inline-block and two nags would otherwise sit side by side inside the landmark.

About screens hide notices inside .about__container, so the "Upgrade Network" notice no longer shows on network/about.php?updated (it still shows on all other network screens).

Trac ticket: https://core.trac.wordpress.org/ticket/66302

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Sonnet 5.5
Used for: Drafting the fix and PR description; final implementation and verification reviewed by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Adi-ty
Adi-ty marked this pull request as ready for review October 13, 2026 17:39
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props iamadisingh.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant