Repository navigation
Conversation
…bled. QuickTags toolbar buttons use the standard .button and .button-small classes whose base styling is provided by buttons.css. On the frontend, wp_editor() force-prints editor.css, but buttons.css was only enqueued, meaning it was not printed if wp_editor() was called after wp_head() ran. This left QuickTags buttons unstyled. This change ensures buttons.css is force-printed alongside editor-buttons when QuickTags is enabled. Props vnoben, wprashed. Fixes #64841.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Description
When
wp_editor()is rendered on the frontend with QuickTags enabled, the QuickTags toolbar renders buttons with the.buttonand.button-smallclasses. In WordPress 6.7, QuickTags buttons were migrated to use standard WordPress button classes whose base styles reside inbuttons.css(handlebuttons).While
editor.css(handleeditor-buttons) is force-printed inline inside_WP_Editors::editor(),buttons.cssis only enqueued inenqueue_scripts()atwp_print_footer_scripts. Ifwp_editor()is called afterwp_head()has fired (as is standard in frontend templates or shortcodes),buttons.csswas not output before the editor, leaving QuickTags buttons unstyled.This PR adds a call to
wp_print_styles( 'buttons' )inside_WP_Editors::editor()when QuickTags is enabled (! empty( $set['quicktags'] )), ensuring the stylesheet is printed alongsideeditor-buttonsand styling the QuickTags buttons correctly.Trac ticket: https://core.trac.wordpress.org/ticket/64841
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.