Skip to content

Plugins: Add 'hello-dolly' text domain to Hello Dolly string #14238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wprashed wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Plugins: Add 'hello-dolly' text domain to Hello Dolly string #14238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-content/plugins/hello.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ function hello_dolly() {

printf(
'<p id="dolly"><span class="screen-reader-text">%s </span><span dir="ltr"%s>%s</span></p>',
__( 'Quote from Hello Dolly song, by Jerry Herman:' ),
__( 'Quote from Hello Dolly song, by Jerry Herman:', 'hello-dolly' ),
$lang,
$chosen
);
Expand Down
36 changes: 36 additions & 0 deletions tests/phpunit/tests/plugins/helloDolly.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<?php

/**
* Tests for the Hello Dolly bundled plugin.
*
* @group plugins
*
* @covers ::hello_dolly
*/
class Tests_Plugins_HelloDolly extends WP_UnitTestCase {

/**
* Tests that hello_dolly() uses the 'hello-dolly' text domain.
*
* @ticket 65676
*/
public function test_hello_dolly_uses_hello_dolly_textdomain() {
require_once ABSPATH . 'wp-content/plugins/hello.php';

$passed_domain = null;
$filter = function ( $translation, $text, $domain ) use ( &$passed_domain ) {
if ( 'Quote from Hello Dolly song, by Jerry Herman:' === $text ) {
$passed_domain = $domain;
}
return $translation;
};

add_filter( 'gettext', $filter, 10, 3 );
ob_start();
hello_dolly();
ob_end_clean();
remove_filter( 'gettext', $filter, 10 );

$this->assertSame( 'hello-dolly', $passed_domain );
}
}
Loading