Repository navigation
Conversation
The quote attribution string in `hello_dolly()` was missing the 'hello-dolly' text domain argument, causing it to fall back to the default core text domain and preventing plugin translations from being loaded. Props fahimmurshed, wprashed. Fixes #65676.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
A test report: I have tested it. Optional suggestions for the author: |
Trac ticket: https://core.trac.wordpress.org/ticket/65676
Description
In
src/wp-content/plugins/hello.php, the quote attribution string insidehello_dolly():was missing the second argument specifying the
'hello-dolly'text domain (declared in the plugin headerText Domain: hello-dolly). As a result, the string fell back to the default WordPress core domain, preventing translations provided by the Hello Dolly localization project on translate.wordpress.org from loading.Solution
'hello-dolly'text domain to__( 'Quote from Hello Dolly song, by Jerry Herman:', 'hello-dolly' )inhello_dolly().tests/phpunit/tests/plugins/helloDolly.phpasserting that the'hello-dolly'text domain is used when translating the quote attribution string.Props: fahimmurshed, wprashed.