Skip to content

Media: Parse only the search term in media grid router when extra query parameters are present #14237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wprashed wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Media: Parse only the search term in media grid router when extra query parameters are present #14237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/js/media/routers/manage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ var Router = Backbone.Router.extend(/** @lends wp.media.view.MediaFrame.Manage.R

// Respond to the search route by filling the search field and triggering the input event.
search: function( query ) {
if ( query ) {
query = query.split( '&' )[0];
}
jQuery( '#media-search-input' ).val( query ).trigger( 'input' );
},

Expand All @@ -39,16 +42,17 @@ var Router = Backbone.Router.extend(/** @lends wp.media.view.MediaFrame.Manage.R
var media = wp.media,
frame = media.frames.browse,
library = frame.state().get('library'),
itemId = parseInt( query, 10 ),
item;

// Trigger the media frame to open the correct item.
item = library.findWhere( { id: parseInt( query, 10 ) } );
item = library.findWhere( { id: itemId } );

if ( item ) {
item.set( 'skipHistory', true );
frame.trigger( 'edit:attachment', item );
} else {
item = media.attachment( query );
item = media.attachment( itemId );
frame.listenTo( item, 'change', function( model ) {
frame.stopListening( item );
frame.trigger( 'edit:attachment', model );
Expand Down
Loading