Skip to content

Media: Ignore the global post in media_handle_sideload() when no post ID is passed. - #14194

Open
nhrrob wants to merge 1 commit into
WordPress:trunkfrom
nhrrob:fix/43119-sideload-empty-post-id
Open

nhrrob wants to merge 1 commit into
WordPress:trunkfrom
nhrrob:fix/43119-sideload-empty-post-id

Conversation

@nhrrob

@nhrrob nhrrob commented Oct 11, 2026

Copy link
Copy Markdown

When media_handle_sideload() is called without a post ID, get_post( 0 ) falls back to the global post, so the file is stored in that post's year/month upload folder instead of the current one. This only looks up the post when a post ID is passed. It refreshes 43119.2.diff with new unit tests that set a global post.

Testing instructions

  1. Create a post dated in the past (for example January 2018).
  2. With that post set as the global $post, sideload a file without a post ID, for example with wp eval:
    require_once ABSPATH . 'wp-admin/includes/media.php';
    require_once ABSPATH . 'wp-admin/includes/file.php';
    require_once ABSPATH . 'wp-admin/includes/image.php';
    $GLOBALS['post'] = get_post( <old post ID> );
    $tmp = wp_tempnam( 'logo.png' );
    copy( ABSPATH . 'wp-includes/images/w-logo-blue.png', $tmp );
    echo get_attached_file( media_handle_sideload( array( 'name' => 'logo.png', 'tmp_name' => $tmp ), 0 ) );
  3. Before: the file is saved in uploads/2018/01/. After: it is saved in the current month's folder.
  4. Run npm run test:php -- --filter Tests_Media_mediaHandleSideload.

Trac ticket: https://core.trac.wordpress.org/ticket/43119

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Refreshing the existing patch, writing the unit tests and verifying with WP-CLI; reviewed and tested by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

… ID is passed.

`get_post( 0 )` falls back to the global post, so a file sideloaded without a
post ID was stored in that post's year/month folder. Only look up the post when
a post ID is passed.

See #43119.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props nhrrob.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant