Skip to content

Toolbar: Allow hreflang, aria-describedby and data attributes on admin bar nodes. - #14191

Open
nhrrob wants to merge 1 commit into
WordPress:trunkfrom
nhrrob:fix/38636-admin-bar-attributes
Open

Toolbar: Allow hreflang, aria-describedby and data attributes on admin bar nodes.#14191
nhrrob wants to merge 1 commit into
WordPress:trunkfrom
nhrrob:fix/38636-admin-bar-attributes

Conversation

@nhrrob

@nhrrob nhrrob commented Oct 11, 2026

Copy link
Copy Markdown

Lets admin bar nodes pass hreflang, aria-describedby and valid data-* attributes through meta. This refreshes 38636.selective.patch against trunk, checks data-* names against a pattern so they can't inject markup, keeps data-* values such as 0, and adds unit tests. aria-current is left for a follow-up.

Testing instructions

  1. Add this to an mu-plugin: 
    add_action( 'admin_bar_menu', function ( $bar ) {
	$bar->add_node( array(
		'id'    => 'test',
		'title' => 'Test',
		'href'  => 'https://example.org/nl/',
		'meta'  => array(
			'hreflang'           => 'nl',
			'aria-describedby'   => 'wp-admin-bar-test-desc',
			'data-test'          => 'value',
			'data-count'         => 0,
			'data-x onmouseover' => 'alert(1)',
		),
	) );
	$bar->add_node( array( 'id' => 'test-desc', 'parent' => 'test', 'title' => 'Opens the Dutch site' ) );
}, 999 );
  2. Load any admin or front-end page and inspect the "Test" link in the toolbar.
  3. Before: the link has none of the extra attributes. After: it has hreflang="nl", aria-describedby="wp-admin-bar-test-desc" data-test="value" and data-count="0", and still has no onmouseover.
  4. Run npm run test:php -- --filter Tests_AdminBar.

Trac ticket: https://core.trac.wordpress.org/ticket/38636

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Refreshing the existing patch, writing the unit tests and verifying in a browser; reviewed and tested by me.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@nhrrob
Toolbar: Allow hreflang, aria-describedby and data attributes on admi…
1a71a61 
…n bar nodes.

Admin bar nodes can now pass `hreflang` (links only), `aria-describedby` and
`data-*` attributes in `meta`. Data attribute names are validated, and values
such as `0` are kept.

See #38636.
@github-actions

github-actions Bot commented Oct 11, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props nhrrob.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Oct 11, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nhrrob