Repository navigation
Conversation
Buttons with aria-disabled="true" remain focusable, but when they also have the disabled class, the disabled styles remove the focus ring via box-shadow: none !important. Restore the standard focus style for them. See #66271.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Restores the focus ring on
aria-disabled="true"buttons that also have the.disabledclass, which currently removes it viabox-shadow: none !important.Testing instructions
<div class="wp-core-ui"><button type="button" class="button button-primary disabled" aria-disabled="true">Primary</button> <button type="button" class="button disabled" aria-disabled="true">Secondary</button></div>Trac ticket: https://core.trac.wordpress.org/ticket/66271
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Drafting the CSS change and verifying it with Playwright; reviewed and tested by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.