Skip to content

Site Health: Improve robots.txt detection for subdirectory sites. - #14073

Open
Sourav61 wants to merge 1 commit into
WordPress:trunkfrom
Sourav61:66060-site-health-robots-txt
Open

Sourav61 wants to merge 1 commit into
WordPress:trunkfrom
Sourav61:66060-site-health-robots-txt

Conversation

@Sourav61

@Sourav61 Sourav61 commented Oct 7, 2026

Copy link
Copy Markdown

This PR improves Site Health's robots.txt detection for installations where WordPress is installed in a subdirectory or where the web server document root differs from the WordPress home path.

Previously, Site Health checked get_home_path() . 'robots.txt', which could incorrectly report that WordPress was dynamically generating robots.txt when a static file existed at the web server's document root.

The robots.txt detection is moved into a dedicated helper and now considers the server document root when determining whether a static file exists at the root of the site's domain.

When DOCUMENT_ROOT and get_home_path() differ and the public robots.txt location cannot be determined reliably, Site Health reports that it is unable to determine how the file is served instead of incorrectly reporting a dynamic robots.txt.

The existing messages for static robots.txt, dynamic robots.txt, and unavailable rewrite support remain unchanged.

Testing

Added regression tests for robots.txt reporting across root and subdirectory URLs, file presence, permalink settings, simulated rewrite support, and differing filesystem roots. Tests run in both single-site and multisite modes, including shared physical-file detection for a child site.

Validation: 84 single-site and 85 multisite Site Health tests passed, along with PHP syntax, coding standards, and whitespace checks.

Public /robots.txt responses and custom web-server mappings were not verified. No line or branch coverage percentage was measured.

Trac ticket: https://core.trac.wordpress.org/ticket/66060

Use of AI Tools

AI assistance: Yes
Tool(s): ChatGPT
Model(s): GPT-5.6 Sol
Used for: Reviewing the proposed approach, discussing edge cases and test scenarios. The implementation and tests were reviewed and validated by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sourav08.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant