Repository navigation
Code Quality: Simplify redundant conditions and font MIME type handling - #13882
arshidkv12 wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
In 65817
Simplify redundant conditions in
human_time_diff()by removing lower-bound checks that are already guaranteed by the preceding conditions. r21996Also simplify the TTF MIME type handling in
WP_Font_Utilsnow thatfont/sfntcan be used directly, removing the obsolete PHP-version-specific fallback. r57539These changes make the conditions easier to read and allow the
greaterOrEqual.alwaysTruePHPStan baseline to be removed.Use of AI Tools
AI assistance: Yes
Tool(s): ChatGPT
Model(s): GPT-5.6 Luna
Used for: Reviewing PHPStan findings and discussing possible fixes. The final implementation and changes were reviewed and made by me.