Repository navigation
Canonical: Redirect the post format, page name and author name query vars to their pretty permalinks. - #13824
Open
Pathan-Amaankhan wants to merge 3 commits into
Open
Pathan-Amaankhan wants to merge 3 commits into
Pathan-Amaankhan wants to merge 3 commits into
Conversation
…vars to their pretty permalinks. With pretty permalinks enabled, `?category_name=`, `?p=`, `?page_id=` and `?author=` requests are redirected to the canonical URL, but `?post_format=`, `?pagename=` and `?author_name=` requests were not. * Pages: `?pagename=` is handled like `?page_id=`, including the static front page and the posts page. * Authors: `?author_name=` follows the rule already used for `?author=`, so only authors with at least one published post are redirected. * Post formats: `_post_format_request()` adds a `post_type` query var to every post format request, which made `redirect_canonical()` treat the request as coming from a rewrite rule. That var is now ignored for post format requests, so `_post_format_request()` itself is unchanged. Extra query args are kept, and requests for content that does not exist are not redirected. See #20902. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…uthor name query vars. The paging and feed handling rebuilds the redirect URL from the requested path, which discarded the URL resolved for `?author_name=`, `?author=` and `?pagename=`. For example, `/?author_name=admin&paged=2` went to `/page/2/` and `/?author=2&feed=rss2` to `/feed/`. Set the path of the resolved URL as well, so that paging and feeds are appended to it, as they are for terms. Requests that cannot be paged that way keep their current behavior: `?pagename=` on a regular page when `paged` is present, and on the posts page when a feed is requested. Adds tests for paging and feeds with post formats, authors, pages and the posts page. See #20902. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
… into fix/20902-canonical-query-vars
Pathan-Amaankhan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/20902
Description
With pretty permalinks enabled,
/?category_name=…,/?p=…,/?page_id=…and/?author=…are redirected to their canonical URLs. The three cases from the ticket were not:/?post_format=image/type/image//?pagename=blog/blog//?author_name=admin/author/admin/Changes in
redirect_canonical():?pagename=is handled like?page_id=, including the static front page (→/), the posts page (the ticket's/?pagename=blogexample, when "blog" is the posts page) and multi-page pages (&page=2→/slug/2/).?author_name=follows the rule already used for?author=: only authors with at least one published post are redirected._post_format_request()adds apost_typequery var to every post format request.redirect_canonical()took that for a var coming from a rewrite rule and skipped the redirect. That var is now ignored for thepost_formattaxonomy._post_format_request()itself is unchanged (itsis_admin()guard exists because of Trac #18475), which is where this differs from WordPress/wordpress-develop#9029.Paging and feeds are added to the resulting URL, as they already are for categories:
/?post_format=audio&paged=2/type/audio/page/2//?author_name=admin&paged=2/author/admin/page/2//?author_name=admin&feed=rss2/author/admin/feed//?pagename=blog&paged=2(posts page)/blog/page/2//?pagename=about&feed=rss2/about/feed/The paging code rebuilds the URL from the requested path, which used to discard the URL found for
?author=. That is why/?author=2&paged=2went to/page/2/and/?author=2&feed=rss2to/feed/. Both now keep the author.?pagename=on a regular page is left alone whenpagedis present, because paging does not apply to a page.Extra query args are kept (
/?pagename=x&foo=bar→/x/?foo=bar). Nothing is redirected for content that does not exist (unknown page, author or post format) or is not public (a draft page, an author without published posts).About
pagedon the Docker development environmentOn a site whose URL has a port, such as the Docker environment on
localhost:8889, no request that carriespagedorfeedis redirected: not even/?paged=1or/?category_name=uncategorized&paged=1on trunk. The paging code builds$redirect_urlwithout the port, so the "protect against chained redirects" check compares it with the requested URL and skips the redirect. That is Trac #57724 and is not changed here. Without a port in the site URL,/?post_format=image&paged=1redirects to/type/image/.Testing instructions
/?post_format=image,/?pagename=<page-slug>and/?author_name=<author-slug>(for example withcurl -I): each should return a 301 to the pretty URL.&foo=bar, kept in the redirect), with values that do not exist and with a draft page (no redirect, still a 404)./?pagename=<that-page>redirects to/or to the posts page URL.npm run test:php -- --group canonical.Tests added: the three scenarios above with extra args, paging, feeds and negative cases in
Tests_Canonical, the front page and posts page inTests_Canonical_PageOnFront, and tests that an author without published posts is not redirected for?author_name=(same as?author=) and that post format requests keep their paging and feed. The audio fixture post now has the Audio format.AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5.5
Used for: Analysing the ticket, the earlier patches, reproducing the issue on a local site, drafting the redirect_canonical() changes and the PHPUnit tests, and running the test suites and PHPCS. I reviewed the code and tests and re-checked the redirects on a local site.