Skip to content

Code Quality: Fix Customizer component PHPDoc types #13795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arshidkv12 wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Code Quality: Fix Customizer component PHPDoc types #13795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79a25a0
Code Quality:Replace empty() checks for Customizer components
arshidkv12 Sep 28, 2026
5989d76
Code Quality:Replace empty() checks for Customizer components
arshidkv12 Sep 28, 2026
820c0b6
Code Quality: Fix empty() is not falsy
arshidkv12 Sep 29, 2026
d167bac
Code Quality: Fix empty() is not falsy
arshidkv12 Sep 29, 2026
3adc9ce
Code Quality: Fix empty() is not falsy
arshidkv12 Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/wp-includes/class-wp-customize-manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ final class WP_Customize_Manager {
* Methods and properties dealing with managing widgets in the Customizer.
*
* @since 3.9.0
* @var WP_Customize_Widgets
* @var WP_Customize_Widgets|null
*/
public $widgets;

/**
* Methods and properties dealing with managing nav menus in the Customizer.
*
* @since 4.3.0
* @var WP_Customize_Nav_Menus
* @var WP_Customize_Nav_Menus|null
*/
public $nav_menus;

Expand Down
20 changes: 0 additions & 20 deletions tests/phpstan/baselines/empty.property.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,6 @@ parameters:
identifier: empty.property
count: 1
path: ../../../src/wp-includes/class-wp-customize-control.php
-
message: '#^Property WP_Customize_Manager\:\:\$nav_menus \(WP_Customize_Nav_Menus\) in empty\(\) is not falsy\.$#'
identifier: empty.property
count: 4
path: ../../../src/wp-includes/class-wp-customize-manager.php
-
message: '#^Property WP_Customize_Manager\:\:\$widgets \(WP_Customize_Widgets\) in empty\(\) is not falsy\.$#'
identifier: empty.property
count: 1
path: ../../../src/wp-includes/class-wp-customize-manager.php
-
message: '#^Property WP_Customize_Panel\:\:\$active_callback \(callable\) in empty\(\) is not falsy\.$#'
identifier: empty.property
Expand All @@ -48,16 +38,6 @@ parameters:
identifier: empty.property
count: 1
path: ../../../src/wp-includes/class-wp-customize-section.php
-
message: '#^Property WP_Customize_Manager\:\:\$nav_menus \(WP_Customize_Nav_Menus\) in empty\(\) is not falsy\.$#'
identifier: empty.property
count: 1
path: ../../../src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php
-
message: '#^Property WP_Customize_Manager\:\:\$nav_menus \(WP_Customize_Nav_Menus\) in empty\(\) is not falsy\.$#'
identifier: empty.property
count: 1
path: ../../../src/wp-includes/customize/class-wp-customize-nav-menu-setting.php
-
message: '#^Property WP_Customize_Partial\:\:\$render_callback \(callable\) in empty\(\) is not falsy\.$#'
identifier: empty.property
Expand Down
Loading