Repository navigation
Code Quality: Fix Customizer component PHPDoc types - #13795
arshidkv12 wants to merge 5 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
github-project-automation
Bot
moved this to Backlog
in WordPress Project Static Analysis Improvements (PHPStan & TypeScript)
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Fixing the two docblocks to WP_Customize_Widgets|null and WP_Customize_Nav_Menus|null clears both baseline entries with zero changes to production code, and leaves the file documenting what actually happens.
|
Thank you |
|
@arshidkv12 the PR title says it replaces the |
arshidkv12
changed the title
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The functional refactor is missing and baseline removals expose unresolved PHPStan errors.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
This PR updates Customizer property annotations and removes related PHPStan baseline suppressions, but does not implement the described empty() check refactor.
Changes:
- Marks widget and navigation-menu properties nullable.
- Removes corresponding PHPStan baseline entries.
- Existing
empty()checks remain, leaving the functional change incomplete.
| File | Summary |
|---|---|
tests/phpstan/baselines/empty.property.neon |
Removes suppressions while the corresponding source checks remain, causing PHPStan failures. |
src/wp-includes/class-wp-customize-manager.php |
Updates annotations, but does not use the filtered component list for starter-content processing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -28,16 +28,6 @@ parameters: | |||
| identifier: empty.property | |||
| count: 1 | |||
| path: ../../../src/wp-includes/class-wp-customize-control.php | |||
| * | ||
| * @since 3.9.0 | ||
| * @var WP_Customize_Widgets | ||
| * @var WP_Customize_Widgets|null |
In 65817
Use the Customizer components list to determine which starter content
should be processed instead of checking whether the corresponding
properties are non-empty. r38991
This ensures that widgets, navigation menus, attachments, and posts
are handled according to the enabled Customizer components.
It also updates the dependency check for the
nav_menus_created_postssetting. r39346Use of AI Tools
AI assistance: Yes
Tool(s): ChatGPT
Model(s): GPT-5.6 Luna
Used for: Reviewing PHPStan findings and discussing possible fixes. The final implementation and changes were reviewed and made by me.