Repository navigation
Conversation
This removes the manually added jQuery Migrate files from the pseudo enqueue directory (`src/js/_enqueues`) which are copied directly over as part of the build process. It instead moves to using NPM for the package, and updates the build scripts to leverage the `node_modules` directory files instead. It also updates the jQuery Migrate version to the latest in the 3.x branch to expose any more warnings in preparation of upgrading to jQuery 4.x in an upcoming core release.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
Thanks @Clorith I've taken some liberties and pushed to your PR:
- 324d5a7: Added jQuery to the data provider used to ensure the package.json version of a dependency matches that registered by the script loader, this resolves the failing tests
- 67ad085: Added a test to ensure the jQuery files exist in the correct location. This passes on both trunk and the feature branch.
The changes look good to me but I'm doing some manual testing before approving for commit.
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com> Co-authored-by: Weston Ruter <westonruter@gmail.com>
Updates jQuery Migrate from 3.4.1 to 3.6.0. This also removes the library from the committed `src/js/_enqueues/vendor/jquery/` directory in favour of updating via NPM. This is the first step in the upgrade path for jQuery 4.0. Developed in #13787. Props clorith, jorbin, mukesh27, westonruter. Fixes #66203. See #60478. git-svn-id: https://develop.svn.wordpress.org/trunk@63983 602fd350-edb4-49c9-b593-d223f7449a82
Updates jQuery Migrate from 3.4.1 to 3.6.0. This also removes the library from the committed `src/js/_enqueues/vendor/jquery/` directory in favour of updating via NPM. This is the first step in the upgrade path for jQuery 4.0. Developed in WordPress/wordpress-develop#13787. Props clorith, jorbin, mukesh27, westonruter. Fixes #66203. See #60478. Built from https://develop.svn.wordpress.org/trunk@63983 git-svn-id: http://core.svn.wordpress.org/trunk@63146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
I created trac-66203 for updating the jQuery Migrate ticket and committed against that rather than the jQuery 4.0 upgrade ticket. |
This removes the manually added jQuery Migrate files from the pseudo enqueue directory (
src/js/_enqueues) which are copied directly over as part of the build process.It instead moves to using NPM for the package, and updates the build scripts to leverage the
node_modulesdirectory files instead.It also updates the jQuery Migrate version to the latest in the 3.x branch to expose any more warnings in preparation of upgrading to jQuery 4.x in an upcoming core release.
Trac ticket: https://core.trac.wordpress.org/ticket/60478
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.