Skip to content

Prevent invalid paragraph nesting in playlist shortcode - #13677

Open
Vedant-Gandhi wants to merge 4 commits into
WordPress:trunkfrom
Vedant-Gandhi:fix/playlist-shortcode-text
Open

Vedant-Gandhi wants to merge 4 commits into
WordPress:trunkfrom
Vedant-Gandhi:fix/playlist-shortcode-text

Conversation

@Vedant-Gandhi

Copy link
Copy Markdown

Description

This PR fixes the invalid behaviour of shortcode_unautop which expands the text content of the shortcode to the whole block causing the entire markup to be wrapped in <p> tag instead of just the text.

Trac ticket: https://core.trac.wordpress.org/ticket/50863

Use of AI Tools

Tools: Claude Web
Models: Sonnet 5
Used For: Brainstorming the root cause and used as a pair programmer. Used to add proper comments, validate the code in terms of performance and write test cases. I have thoroughly reviewed the code and have tested it properly to ensure there are no unintended changes introduced due to AI.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props vedantgandhi28.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant