Skip to content

Add support for setting position in viewport states - #13626

Closed
tellthemachines wants to merge 4 commits into
WordPress:trunkfrom
tellthemachines:add/position-in-viewport-states
Closed

tellthemachines wants to merge 4 commits into
WordPress:trunkfrom
tellthemachines:add/position-in-viewport-states

Conversation

@tellthemachines

@tellthemachines tellthemachines commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/66166

Use of AI Tools

used copilot/gpt 5.6 luna to copy changes across from WordPress/gutenberg#83094
and human reviewed.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@tellthemachines
tellthemachines force-pushed the add/position-in-viewport-states branch from c67ef8d to 1db4cad Compare September 23, 2026 10:05
@tellthemachines
tellthemachines marked this pull request as ready for review September 23, 2026 10:25
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props isabel_brison, ramonopoly.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ramonjd ramonjd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked against WordPress/gutenberg#83094

Tests pass 👍🏻

Comment thread src/wp-includes/block-supports/position.php Outdated
@@ -18,11 +18,6 @@

parameters:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we removed this and the below errors with these changes so we can remove the ignores too

@github-actions

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 63929
GitHub commit: 04e22d9

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants