Skip to content

Tests: Improve isolation for randomized admin tests - #13181

Closed
sirreal wants to merge 3 commits into
WordPress:trunkfrom
sirreal:agent/test-order-admin-isolation
Closed

Tests: Improve isolation for randomized admin tests#13181
sirreal wants to merge 3 commits into
WordPress:trunkfrom
sirreal:agent/test-order-admin-isolation

Conversation

@sirreal

@sirreal sirreal commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Resets admin menu registries and plugin-dependency statics, removes temporary MU-plugin fixtures, isolates list-table screens, and makes updater open_basedir tests account for an external Composer vendor directory.
  • Keeps the changes confined to PHPUnit tests and fixtures.

Verification

  • 100 randomized admin-group runs passed; each completed 1,024 tests and 2,721 assertions with ten known warnings and one skip.
  • The continuation covered seeds 1789072001 through 1789072050; maximum authoritative PHPUnit time was 90.776 seconds.
  • Replayed the original failing seed and focused contaminator/consumer cases during diagnosis.
  • PHP syntax checks passed for every changed PHP file.
  • git diff --check passed.

Trac: https://core.trac.wordpress.org/ticket/65893

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@lancewillett

lancewillett commented Sep 3, 2026

Copy link
Copy Markdown
Member

Refreshed with current trunk in bf55661; the original isolation change remains intact. Validation passed: PHPCS for the four changed files, focused PHPUnit (59 tests, 252 assertions), and a randomized replay (seed 13181; 59 tests, 252 assertions). The focused run is single-site; CI will provide the full matrix.

@lancewillett
lancewillett marked this pull request as ready for review September 7, 2026 21:51
@github-actions

github-actions Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, lancewillett, mindctrl.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

mindctrl
mindctrl reviewed Sep 9, 2026
View reviewed changes
Comment thread tests/phpunit/tests/admin/wpListTable.php Outdated
@lancewillett lancewillett self-assigned this Sep 13, 2026
@lancewillett

lancewillett commented Sep 13, 2026

Copy link
Copy Markdown
Member

https://core.trac.wordpress.org/changeset/63608

wporg-sync pushed a commit that referenced this pull request Sep 13, 2026
@lancewillett
Tests: Improve isolation of admin tests.
c88f515 
Reset menu registries and plugin-dependency static properties before and after tests. Remove the temporary MU-plugin directory after its fixture files are deleted.

Give list-table fixtures distinct screens and preserve whether the original hook suffix was set. Align the comments table's expected primary column with its declared default.

Allow updater tests to load Composer dependencies outside the checkout while exercising open_basedir restrictions.

Developed in: #13181

Props jonsurrell, mindctrl.
See #65893.


git-svn-id: https://develop.svn.wordpress.org/trunk@63608 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Sep 13, 2026
@lancewillett
Tests: Improve isolation of admin tests.
0db8a11 
Reset menu registries and plugin-dependency static properties before and after tests. Remove the temporary MU-plugin directory after its fixture files are deleted.

Give list-table fixtures distinct screens and preserve whether the original hook suffix was set. Align the comments table's expected primary column with its declared default.

Allow updater tests to load Composer dependencies outside the checkout while exercising open_basedir restrictions.

Developed in: WordPress/wordpress-develop#13181

Props jonsurrell, mindctrl.
See #65893.

Built from https://develop.svn.wordpress.org/trunk@63608


git-svn-id: http://core.svn.wordpress.org/trunk@62784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@sirreal
sirreal deleted the agent/test-order-admin-isolation branch September 17, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lancewillett lancewillett lancewillett left review comments
@mindctrl mindctrl Awaiting requested review from mindctrl

Assignees

@lancewillett lancewillett

Labels

None yet

Projects

WordPress Project Build Tooling
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sirreal @lancewillett @mindctrl